Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mono-sgen paxrat problem #59

Open
wants to merge 2 commits into
base: debian
Choose a base branch
from
Open

Conversation

oholiab
Copy link

@oholiab oholiab commented Nov 12, 2017

Fixes build failing without manual intervention due to mono-sgen running as a dependency and failing due to missing PAX flags

Requires subgraph/subgraph-debian-packages#5


apt-get install -y --force-yes paxrat
apt-get install -y --force-yes mono-runtime-sgen
paxrat /usr/bin/mono-sgen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paxrat should be called without any arguments or with different arguments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you or @dma comment on whether no args or different args are preferable, and if different what these should be?

I'll copy the fix over to the other PRs I have for the mono-sgen fix as well once I know what the right flags are.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the flag is present (it might not be if the package is pulled from stretch where the config is frozen), you would just paxrat it with no arguments. This will apply the flags from /etc/paxrat/paxrat.conf. If the flag is not present, it can be added to the conf first.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No args should work in all cases when the binary is included with flags in /etc/paxrat/paxrat.conf.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'll try to get this done over the weekend because I want to test the change before I commit it :)

Copy link

@kibal kibal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you remove the package name from the paxrat call, we will merge these changes.


apt-get install -y --force-yes paxrat
apt-get install -y --force-yes mono-runtime-sgen
paxrat /usr/bin/mono-sgen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No args should work in all cases when the binary is included with flags in /etc/paxrat/paxrat.conf.

@oholiab
Copy link
Author

oholiab commented Dec 18, 2017

I just tested this with no flags and it built just fine :)

@oholiab oholiab closed this Dec 18, 2017
@oholiab
Copy link
Author

oholiab commented Dec 18, 2017

Sorry, didn't mean to hit the close button -_-

@oholiab oholiab reopened this Dec 18, 2017
@mamdoh-ahmed
Copy link

hi everybody i am start on linux not long while i use fedora 27 i want to build fw daemon and i don't know how please can you help me and i sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants